cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

New Command pp website webfile get

Open ktskumar opened this issue 1 year ago • 1 comments

Closes #6273

Added new command pp website webfile get

ktskumar avatar Oct 12 '24 02:10 ktskumar

Hi @ktskumar thank you for creating yet another PR, we're truly grateful for that. However, I've noticed that you are creating new commands using our old approach. For about 2 months, we switched the structure for commands. Since then, we have required all new commands to implement ZOD instead of using the old approach with option interfaces. Please, keep in mind next time that new commands should use a ZOD scheme. You can find some examples at: login, flow recyclebinitem list, flow recyclebinitem restore, spo site get, spo site sharingpermission set, ...

milanholemans avatar Oct 12 '24 13:10 milanholemans

@ktskumar I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍 Thanks for your support and awesome contribution 👏 You Rock 🤩

Adam-it avatar Oct 29 '24 10:10 Adam-it

Considering the inactivity period, I'll proceed closing these PR's as stale. Feel free to reopen and rework if you've got the time. But if you do, please request reassignment of the issue so we know you're working on it!

Kind regards!

martinlingstuyl avatar Jan 24 '25 15:01 martinlingstuyl