cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

Adds 'spe container get' command. Closes #6083

Open nanddeepn opened this issue 1 year ago â€ĸ 2 comments

Adds spe container get command. Closes #6083

nanddeepn avatar Oct 09 '24 17:10 nanddeepn

Thank you, we'll try to review it ASAP!

milanholemans avatar Oct 09 '24 18:10 milanholemans

Hi @nanddeepn, just to inform you, when developing new commands, we require all new commands to use ZOD instead of the old implementation. ZOD simplifies validating options and setting up telemetry. If you're looking for examples, you can check login, flow recyclebinitem restore, flow recyclebinitem list and few other commands. So next time, please, use the new ZOD approach, thanks!

milanholemans avatar Oct 09 '24 18:10 milanholemans

@nanddeepn I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍 Thanks for your support and awesome contribution 👏 You Rock 🤩

Adam-it avatar Oct 29 '24 10:10 Adam-it

Ready to merge 🚀

Adam-it avatar Nov 25 '24 21:11 Adam-it

@nanddeepn I tried to merge this one but I had a really hard time doing so due to almost 40 commits that are not part of this change 😮. I think something got wrong when you rebased this branch against main 🤔. May I kindly ask you to try to rebase it again or open a new PR with your changes and just tag me over in that one so that it will get me unblocked to move forward with this change? 🙏 Sorry for the inconvenience

Adam-it avatar Nov 26 '24 04:11 Adam-it

@pnp/cli-for-microsoft-365-maintainers due to my short brake I am unassigning myself from this one so that it may be processed by someone else

Adam-it avatar Nov 26 '24 08:11 Adam-it

Hi @Adam-it I have raised a new PR at https://github.com/pnp/cli-microsoft365/pull/6507 Closing this one. Please review.

nanddeepn avatar Nov 28 '24 10:11 nanddeepn

Hi @Adam-it I have raised a new PR at https://github.com/pnp/cli-microsoft365/pull/6507 Closing this one. Please review.

Thank you for letting me know. I will let the team know that this PR is ready to be merged and someone else will process it as in December I will be on a short break from this repo. Unfortunately it will be very hard for me to find even 10 min time for activities in this project during this month â˜šī¸

Adam-it avatar Nov 28 '24 11:11 Adam-it

Hi @Adam-it I have raised a new PR at #6507 Closing this one. Please review.

Thank you for letting me know. I will let the team know that this PR is ready to be merged and someone else will process it as in December I will be on a short break from this repo. Unfortunately it will be very hard for me to find even 10 min time for activities in this project during this month â˜šī¸

Totally understand, and I appreciate your efforts so far. Enjoy your well-deserved break!

nanddeepn avatar Nov 28 '24 11:11 nanddeepn

Totally understand, and I appreciate your efforts so far. Enjoy your well-deserved break!

Thanks 🤩😍. Unfortunately it's not a break but I will be super engaged in other work and I will simply have even less time then usual 😅

Adam-it avatar Nov 28 '24 11:11 Adam-it