cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard
verified publisher icon pnp

Adds command `spp model remove`. Closes #6118

Open mkm17 opened this issue 1 year ago • 1 comments

Adds command spp model remove. Closes #6118

mkm17 avatar Oct 06 '24 10:10 mkm17

Thank you, well try to review it ASAP!

milanholemans avatar Oct 06 '24 21:10 milanholemans

@mkm17 I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍 Thanks for your support and awesome contribution 👏 You Rock 🤩

Adam-it avatar Oct 29 '24 10:10 Adam-it

Hi @milanholemans, ok thank you for the review. You are right, I now understand the odata.null case.

mkm17 avatar Nov 17 '24 20:11 mkm17

@milanholemans I hope the changes to the tests are fine. I've included the same check for the .classifier suffix as in the model get command.

mkm17 avatar Nov 21 '24 22:11 mkm17

Merged manually, thank you!

milanholemans avatar Nov 24 '24 21:11 milanholemans