cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

Adds `spp model get` command Closes #6105

Open mkm17 opened this issue 1 year ago • 1 comments

Adds spp model get command Closes #6105

mkm17 avatar Oct 06 '24 10:10 mkm17

Thank you, well try to review it ASAP!

milanholemans avatar Oct 06 '24 21:10 milanholemans

I have converted it to draft, as there are some conflicts to be resolved.

mkm17 avatar Oct 25 '24 07:10 mkm17

@mkm17 I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍 Thanks for your support and awesome contribution 👏 You Rock 🤩

Adam-it avatar Oct 29 '24 10:10 Adam-it

@milanholemans thank you again for the review. I believe I have addressed all the suggested changes. I have one question regarding the tests: I updated it to assert.strictEqual(JSON.stringify(loggerLogSpy.lastCall.args[0]), JSON.stringify(modelResult)); instead of the previous approach. Is that ok?

mkm17 avatar Nov 21 '24 21:11 mkm17

@milanholemans thank you again for the review. I believe I have addressed all the suggested changes. I have one question regarding the tests: I updated it to assert.strictEqual(JSON.stringify(loggerLogSpy.lastCall.args[0]), JSON.stringify(modelResult)); instead of the previous approach. Is that ok?

Is there a reason why we stringify everything instead of using assert.deepStrictEqual?

milanholemans avatar Nov 21 '24 21:11 milanholemans

@milanholemans I saw this method somewhere in the code, but definitely it is a much better idea. Thank you.

mkm17 avatar Nov 22 '24 07:11 mkm17

@milanholemans Thank you for the review. The changes have been applied to the new version.

mkm17 avatar Dec 01 '24 21:12 mkm17

Merged manually, thanks!

milanholemans avatar Dec 22 '24 17:12 milanholemans