cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard
verified publisher icon pnp

Adds `engage community user add`. Closes #6293

Open MathijsVerbeeck opened this issue 1 year ago • 2 comments

Closes #6293

MathijsVerbeeck avatar Sep 26 '24 17:09 MathijsVerbeeck

Hi @MathijsVerbeeck, do you have the time to conclude the work on these two viva PR's soon? I'm in the presupposition they need to be included in v10. So I'd hope to merge them sometime soon.

martinlingstuyl avatar Oct 14 '24 11:10 martinlingstuyl

@MathijsVerbeeck, since you're using the same util, I’ve already applied the changes @martinlingstuyl recommended. You can check it out here: #6371.

Jwaegebaert avatar Oct 18 '24 12:10 Jwaegebaert

Whats the status here @MathijsVerbeeck? It's marked PR-major. But we'll need to do some work yet to include it.

martinlingstuyl avatar Oct 21 '24 18:10 martinlingstuyl

I am removing the pr-major label from this PR as we agreed to proceed with this change the 'standard' way and the removal of the group commands as breaking change that will target v11

Adam-it avatar Oct 30 '24 22:10 Adam-it

Merged manually, huge thanks!! 🚀🚀

martinlingstuyl avatar Mar 11 '25 07:03 martinlingstuyl