pnp
Replaces deprecated methods
Hi @milanholemans, could you please re-run the workflow? Seems like a random error. Thanks
Not sure right now, but the error on macos
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
Can be related to eslint-plugin-deprecation https://github.com/gund/eslint-plugin-deprecation/issues/67
Not sure right now, but the error on macos
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
Can be related to eslint-plugin-deprecation gund/eslint-plugin-deprecation#67
Hmm that's quite problematic.
If it's failing our pipelines, and we can't fix it, we should consider something else.
I have also encountered an issue with increased execution time of the linting. The CLI for M365 has a large code base, the performance of this plugin is really bad.
In the worst case, we can get rid of the plugin eslint-plugin-deprecation and keep the refactored code.
I have also encountered an issue with increased execution time of the linting. The CLI for M365 has a large code base, the performance of this plugin is really bad.
In the worst case, we can get rid of the plugin eslint-plugin-deprecation and keep the refactored code.
That's a pity. Like you mentioned, if we can't get it to work, we'll just review the refactored code.
@waldekmastykarz eslint-plugin-deprecation was causing the error when running test on macos.
FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
Similar to https://github.com/gund/eslint-plugin-deprecation/issues/67
https://github.com/pnp/cli-microsoft365/actions/runs/10370949281/job/28746774555
and increased execution time of the linting, because the CLI for M365 has a large code base, the performance of this plugin is really bad.
I only refactored deprecated functions.
Thanks for clarifying. Let's update the PR's title to communicate this more clearly.
