cli-microsoft365 All entra m365group commands should accept displayName option

Closes #6147

Aug 09 '24 07:08 MartinM85

Thank you @MartinM85 we'll try to review it ASAP

Aug 09 '24 11:08 milanholemans

Hi @MartinM85, could you resolve the merge conflicts by rebasing with the latest main, please?

Aug 24 '24 17:08 milanholemans

@milanholemans Two commands where extended with groupName option. What's the correct option name? Still groupDisplayName?

Aug 24 '24 19:08 MartinM85

We've renamed a bunch of commands from groupDisplayName to groupName https://github.com/pnp/cli-microsoft365/issues/5616 So groupName is the option name we should use.

Aug 24 '24 19:08 milanholemans

@MartinM85 may I kindly ask you to rebase the PR again before I may proceed with the review. @milanholemans if we in this PR we are changing the groupDisplayName to groupName like in docs/docs/cmd/entra/m365group/m365group-conversation-post-list.mdx isn't this breaking change and this should be a pr-major as we may only do that now with the v10 release?

Oct 16 '24 20:10 Adam-it

@MartinM85 may I kindly ask you to rebase the PR again before I may proceed with the review. @milanholemans if we in this PR we are changing the groupDisplayName to groupName like in docs/docs/cmd/entra/m365group/m365group-conversation-post-list.mdx isn't this breaking change and this should be a pr-major as we may only do that now with the v10 release?

That wasn't really the purpose of the issue, but the commands should be aligned indeed. You are right.

Oct 16 '24 21:10 milanholemans

@Adam-it Hope I've rebased everything correctly

Oct 17 '24 06:10 MartinM85

That wasn't really the purpose of the issue, but the commands should be aligned indeed. You are right.

Ok I will add pr-major label to this PR since now it is a breaking change

Oct 17 '24 06:10 Adam-it

Hi @Adam-it, I had a typo in dispalyName.

Nov 06 '24 07:11 MartinM85

Hi @Adam-it, I had a typo in dispalyName.

Thanks for the quick turn around. I will try to make more reviews this week and for sure will retake this one as well

Nov 06 '24 07:11 Adam-it

Read to merge 🚀

Nov 14 '24 21:11 Adam-it

Merged manually. Thank you for your awesome work! You Rock !🤩 @MartinM85 I noticed that you have been doing a looooot of awesome stuff in CLI repo 🚀. I was wondering if you would like to present some of your work, what you added to the CLI, or how you go about it, or why you do it, or how you use CLI.. etc to the community on one of the PnP Community calls?

Nov 15 '24 23:11 Adam-it

@Adam-it I can try to present some of my work on the PnP Community calls, but I can't say now what exactly. :)

Nov 22 '24 05:11 MartinM85

@Adam-it I can try to present some of my work on the PnP Community calls, but I can't say now what exactly. :)

that's awesome to hear 🤩. You may more than one demo if you want 😉. There are plenty of awesome stuff you did that may be presented 👏 May I kindly ask you to fill out the form so that we may set a demo spot for you https://forms.office.com/pages/responsepage.aspx?id=v4j5cvGGr0GRqy180BHbR8ke1rGfE-VNsUHrnMWCrL5UNjhIVEc4VERQUDNYOTM4MDdKN1ZLWFVBMSQlQCN0PWcu

Nov 22 '24 23:11 Adam-it