cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

Enhance `spo file roleassignment` commands with Microsoft Entra groups

Open milanholemans opened this issue 1 year ago • 5 comments

Related to #6179


Let's extend command spo file roleassignment add and spo file roleassignment remove with 2 new options to add/remove Microsoft Entra groups.

Options Description
--entraGroupId [entraGroupId] ID of the Microsoft Entra group to add/remove. Specify either entraGroupId, entraGroupName, ...
--entraGroupName [entraGroupName] Display name of the Microsoft Entra group to add/remove. Specify either entraGroupId, entraGroupName, ...

Additionally, we should update the description of option --groupName [groupName] and make clear that this option is only used for SharePoint Online groups.


Todo:

  • [ ] Introduce 2 new options to add and remove command.
  • [ ] Clarify that option groupName is only for SharePoint Online groups.

milanholemans avatar Jul 27 '24 23:07 milanholemans

May I work on this

ktskumar avatar Sep 25 '24 05:09 ktskumar

Hey @ktskumar, thank you for all the hard work you’ve put in, it’s really appreciated! We’ve noticed that you have several issues assigned that haven't yet been created with a PR. To ensure everyone has a chance to get involved, especially with Hacktoberfest, I’ll be unassigning you from some of these issues.

We recommend focusing on 1 to 2 issues at a time. Once you’ve submitted a PR for an issue, you can easily claim another open one. This approach helps you manage the workload more effectively and ensures you can give each task the attention it needs.

Thanks again for your continued contributions!

Jwaegebaert avatar Sep 26 '24 11:09 Jwaegebaert

May I work on this

ktskumar avatar Oct 08 '24 06:10 ktskumar

Hi, @ktskumar, you can work on it when you've solved another issue, all right?

milanholemans avatar Oct 08 '24 07:10 milanholemans

I'll take this up. Can you assign this to me

ktskumar avatar Oct 15 '24 00:10 ktskumar