cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

Enhancement: return more properties for `entra m365group get`

Open milanholemans opened this issue 1 year ago • 3 comments

We're currently working on: #5480

Sadly enough, we cannot read these properties using CLI. These properties are not included in the default result returned by Graph. I suggest that we either include them by default, or we add a new flag --includeDetails that will retrieve extra properties.

The properties I'm currently interested in are: allowExternalSenders, autoSubscribeNewMembers, hideFromAddressLists, hideFromOutlookClients, isSubscribedByMail

I'm afraid that we have to make an additional Graph request to retrieve these properties, so I'm personally tending to --includeDetails. What is your opinion on this @pnp/cli-for-microsoft-365-maintainers?

Choice 1) Include extra properties by default Choice 2) Add a new option --includeDetails to retrieve extra properties that we append to the default response.


We agreed to use choice 1.

milanholemans avatar Jul 13 '24 22:07 milanholemans

I vote for option 1. I don't see any huge risk in including this by default

Adam-it avatar Jul 14 '24 23:07 Adam-it

Nice one noticing this, I would also tend more to option one. As it isn't the most complex properties to add to the response so would seem a bit overkill to create an additional option just to fetch those.

Jwaegebaert avatar Jul 15 '24 07:07 Jwaegebaert

May I take this up?

ktskumar avatar Aug 07 '24 01:08 ktskumar

HI @milanholemans ,

Graph AI does not return all properties by default. We have two options to address this:

  1. Include all the properties in a single request using the $select parameter.
  2. Make two separate requests—one for the default properties and another for the additional properties—and then combine the results.

Which option we can choose?

ktskumar avatar Sep 22 '24 04:09 ktskumar

You can't retrieve all properties in one request right? If I'm not mistaken, we'll have to do an additional request.

milanholemans avatar Sep 22 '24 08:09 milanholemans