cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

Removes aad options. Closes #5823

Open nanddeepn opened this issue 1 year ago • 5 comments

Removes aad options. Closes #5823 and #5676

nanddeepn avatar Jul 12 '24 10:07 nanddeepn

Thanks @nanddeepn!

milanholemans avatar Jul 12 '24 11:07 milanholemans

hey @nanddeepn may I kindly ask you to rebase with latest v9 and resolve the conflicts before we proceed 👍. Let me know if you need any kind of help. Thank you for your constant work and contributions to the community 👏. You Rock 🤩

Adam-it avatar Aug 03 '24 20:08 Adam-it

@nanddeepn this change is almost same as #6131. Lets concat those two PR's to a single change closing both issues. Please let's leave the upgrade guidance from this PR since it is really helpful but we also need to add this new page to sidebar.ts 👍

Adam-it avatar Aug 11 '24 21:08 Adam-it

Hi @Adam-it Concating two PRs to close #5823 and #5676

nanddeepn avatar Aug 14 '24 10:08 nanddeepn

Hi @Adam-it Concating two PRs to close #5823 and #5676

Awesome 🤩😍

Adam-it avatar Aug 14 '24 10:08 Adam-it

Due to an upcoming breaking change connected to CLI for Microsoft 365 login experience we will need to do a v9 release a bit sooner than we anticipated. Due to that we had to change the target of this PR to v10 which will be the next regular major release.

Adam-it avatar Aug 30 '24 22:08 Adam-it

@nanddeepn I am terribly sorry for a long hold up from my side due to other priority activities. May I kindly ask you to rebase this branch with latest main so that we may proceed with the review?

Adam-it avatar Oct 11 '24 08:10 Adam-it

Ready to merge 🚀

Adam-it avatar Oct 13 '24 19:10 Adam-it

Merged manually. Thank you for your awesome contribution 👏. You Rock 🤩

Adam-it avatar Oct 13 '24 20:10 Adam-it