cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard
verified publisher icon pnp

Adds a new command: 'spo site admin remove'. Closes #5884

Open mkm17 opened this issue 1 year ago • 4 comments

Adds a new command: 'm365 spo site admin remove'.

Closes #5884

Related tasks #5874.

Similar PR #5926

mkm17 avatar May 20 '24 14:05 mkm17

Thank you, we'll try to review it ASAP!

milanholemans avatar May 20 '24 14:05 milanholemans

Here, the same change mentioned in this code review will be applied: using spo.getSiteId() to get the site ID in admin mode.

mkm17 avatar Jul 03 '24 20:07 mkm17

@mkm17, a few conflicts arose with the latest changes. Could you take a look at them?

Jwaegebaert avatar Jul 09 '24 11:07 Jwaegebaert

@Jwaegebaert thank you for the reminder, I have corrected it

mkm17 avatar Jul 10 '24 14:07 mkm17

@mkm17 may I kindly ask you to rebase this PR against the latest main and resolve the conflicts 🙏. After that we are ready to merge 🚀

Adam-it avatar Sep 17 '24 23:09 Adam-it

@Adam-it Ok, let me review conflicts and I will check if this command has included all changes as in spo admin site membership and spo site admin add requested by Milan in different PRs

mkm17 avatar Sep 18 '24 09:09 mkm17

@Adam-it Ok, let me review conflicts and I will check if this command has included all changes as in spo admin site membership and spo site admin add requested by Milan in different PRs

Awesome. Thanks for the update Let's leave it for now in progress 👍

Adam-it avatar Sep 18 '24 10:09 Adam-it

Ok @Adam-it, I have made adjustments in both the tests and the command. Now it’s similar to the 'spo site admin add' command.

mkm17 avatar Sep 18 '24 20:09 mkm17

Ready to merge 🚀

Adam-it avatar Sep 18 '24 21:09 Adam-it

Merged manually. Thank you for your awesome work 👍 You Rock 🤩

Adam-it avatar Sep 18 '24 23:09 Adam-it