cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

Published 20 hours ago • verified publisher icon pnp

New command: 'm365 entra pim role assignment eligibility list'. Closes #5783

Open MartinM85 opened this issue 10 months ago • 1 comments

Closes #5783

MartinM85 avatar Apr 10 '24 08:04 MartinM85

Thanks @MartinM85! We'll try to look at it ASAP!

milanholemans avatar Apr 10 '24 08:04 milanholemans

@MartinM85 Great start. I have added some remarks, but it seems that I did an oopsie so they are listed quite strange. Could you please have a look at them?

MathijsVerbeeck avatar May 25 '24 11:05 MathijsVerbeeck

@MathijsVerbeeck Thank you for the feedback. All comments resolved. At the first sight I don't see any issue when retrieving assignments. Could you include more details?

MartinM85 avatar May 25 '24 18:05 MartinM85

@MathijsVerbeeck Thank you for the feedback. All comments resolved.

At the first sight I don't see any issue when retrieving assignments. Could you include more details?

I was talking about my review. Your code was working fine!

I'll have another look ASAP.

MathijsVerbeeck avatar May 25 '24 18:05 MathijsVerbeeck

Thanks for the contribution @MartinM85 . Manually merged.

MathijsVerbeeck avatar Jun 18 '24 20:06 MathijsVerbeeck