cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

New command: `m365 spo folder sharinglink remove`

Open MathijsVerbeeck opened this issue 10 months ago • 6 comments

Usage

m365 spo folder sharinglink remove [options]

Description

Removes a sharing link from a folder

Options

Option Description
-u, --webUrl <webUrl> The URL of the site where the file is located
--folderUrl [folderUrl] The server- or site-relative decoded URL of the folder. Specify either folderUrl or folderId but not both
--folderId [folderId] The unique ID (GUID) of the folder. Specify either folderUrl or folderId but not both
-i, --id <id> The sharing link ID
-f, --force Don't prompt for confirmation

Examples

Removes a specific sharing link from a folder by id without prompting for confirmation

m365 spo folder sharinglink remove --webUrl https://contoso.sharepoint.com/sites/demo --folderId daebb04b-a773-4baa-b1d1-3625418e3234 --id 1 --force

Removes a specific sharing link from a folder by url with prompting for confirmation

m365 spo folder sharinglink remove --webUrl https://contoso.sharepoint.com/sites/demo --fileUrl /sites/demo/shared%20documents/Folder --id 1

Default properties

No response

Additional Info

The API call to removea sharing link can be found on the following documentation: https://learn.microsoft.com/en-us/graph/api/permission-delete?view=graph-rest-1.0&tabs=http

Please try to use the SP REST API v2.1 as much as possible to reduce the need for extra Graph permissions.

MathijsVerbeeck avatar Apr 05 '24 20:04 MathijsVerbeeck

you have a small glitch in -i, --id <id>] it should be -i, --id <id> without the ]. Also I would write sharing link ID instead of The ID of the sharing link. Besides that LGTM 👍 @pnp/cli-for-microsoft-365-maintainers anyone else for a 👀

Adam-it avatar Apr 10 '24 21:04 Adam-it

My remarks:

  • Instead of Removes a sharing link of a folder, I'd use Removes a sharing link from a folder
  • folderUrl: should allow server and site-relative URLs
  • folderId: unique ID are 2 words
  • Let's add a remark with the Graph docs for the request
  • Let's add a remark that says that we should use v2.1 SP REST API endpoint as much as possible, this to reduce the need for people to consent extra Microsoft Graph permissions on their app registration.

milanholemans avatar Apr 10 '24 21:04 milanholemans

The specs look good enough for me. Would you like to work on this @MathijsVerbeeck, or open it up?

Jwaegebaert avatar Apr 16 '24 06:04 Jwaegebaert

You can open it up. I do still have some research however on how to retrieve the driveitemid from a folder, as this is not that straightforward as with a file. Should I post this procedure on every command (maybe add it in the specs)?

MathijsVerbeeck avatar Apr 16 '24 06:04 MathijsVerbeeck

Can I take this as well? I will be working on the List command today.

Saurabh7019 avatar Apr 24 '24 06:04 Saurabh7019

All yours @Saurabh7019 . Thanks for your help!

arjunumenon avatar Apr 24 '24 10:04 arjunumenon