cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

Published 20 hours ago • verified publisher icon pnp

New command: m365 file move. Closes #4607

Open Saurabh7019 opened this issue 11 months ago • 1 comments

Closes #4607

Saurabh7019 avatar Mar 05 '24 12:03 Saurabh7019

Thank you, we'll try to review it ASAP!

milanholemans avatar Mar 05 '24 22:03 milanholemans

ready to merge 🚀. Before I merge @Saurabh7019 lets check one comment/question I left in the review

Adam-it avatar Sep 17 '24 08:09 Adam-it

Merged manually. Thank you for your awesome work 👍 You Rock 🤩

Adam-it avatar Sep 18 '24 23:09 Adam-it

@Adam-it, We have a drive.ts utility class, and we should use that instead of driveUtil.ts. I apologize for the delay in addressing this, but I believe this command can be optimized. What is the best way to implement this change and raise the PR?

Saurabh7019 avatar Sep 27 '24 10:09 Saurabh7019

@Adam-it, We have a drive.ts utility class, and we should use that instead of driveUtil.ts. I apologize for the delay in addressing this, but I believe this command can be optimized. What is the best way to implement this change and raise the PR?

Let's open a separate issue describing exactly that and resolve it with a new PR. Don't worry. There is always room for improvements 👍

Adam-it avatar Sep 27 '24 10:09 Adam-it