cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

Published 20 hours ago • verified publisher icon pnp

Refactor codebase to async/await - leftover `src` files

Open MathijsVerbeeck opened this issue 1 year ago • 10 comments

Closes #5147

MathijsVerbeeck avatar Feb 11 '24 13:02 MathijsVerbeeck

Thank you @MathijsVerbeeck, we'll try to review it ASAP!

milanholemans avatar Feb 11 '24 15:02 milanholemans

Hi @MathijsVerbeeck, could you rebase this PR on main and fix the merge conflicts? The multi-account feature that is released has caused this. 😅

martinlingstuyl avatar Feb 28 '24 12:02 martinlingstuyl

Hi @MathijsVerbeeck, could you rebase this PR on main and fix the merge conflicts? The multi-account feature that is released has caused this. 😅

Should be done!

MathijsVerbeeck avatar Feb 28 '24 19:02 MathijsVerbeeck

Hi @MathijsVerbeeck, you may have forgotten about this PR? Maybe you could find some time to fix it, so we can get it in? Let me know if you need any help!

martinlingstuyl avatar May 03 '24 07:05 martinlingstuyl

@martinlingstuyl definitely not, I have asked a question but it seems that you didn't notice that question 😁

MathijsVerbeeck avatar May 03 '24 07:05 MathijsVerbeeck

@martinlingstuyl definitely not, I have asked a question but it seems that you didn't notice that question 😁

Ah, my bad :-) I'll check it out...

martinlingstuyl avatar May 03 '24 07:05 martinlingstuyl

@martinlingstuyl I think that we are there. Could you please have another look?

MathijsVerbeeck avatar May 03 '24 19:05 MathijsVerbeeck

Could you fix the merge conflicts here @MathijsVerbeeck? I'll try to merge it next week!

martinlingstuyl avatar Aug 14 '24 19:08 martinlingstuyl

sorry for the long wait!

martinlingstuyl avatar Aug 14 '24 19:08 martinlingstuyl

They should be resolved. No worries about the delay 😄

MathijsVerbeeck avatar Aug 15 '24 18:08 MathijsVerbeeck