cli-microsoft365
cli-microsoft365 copied to clipboard
pnp
Enhancement: List all properties returned by Graph when using `m365 aad user list`
Idea
Currently this command "m365 aad user list" return only userprincipalname and display name, would be great if it could return same number properties as graph API does by default.
Additional Info
one suggestion: from @Adam-it we could just modify this https://github.com/pnp/cli-microsoft365/blob/f8f3553c972f6064df03ea17e193be07b2b77d79/src/m365/aad/commands/user/user-list.ts#L57-L59 not to trim to ['userPrincipalName', 'displayName'];
Great suggestion @ValerasNarbutas. To me it doesn't make much sense that we aren't returning all properties we retrieve from Graph.
My suggestion would be, instead of introducing a new option, let's just return all properties from Graph when running m365 aad user list (so when no --properties option is passed).
Great suggestion @ValerasNarbutas. To me it doesn't make much sense that we aren't returning all properties we retrieve from Graph. My suggestion would be, instead of introducing a new option, let's just return all properties from Graph when running
m365 aad user list(so when no--propertiesoption is passed).
totally agree, this is my first command example.. i have to do 2 examples as per requirement :D. A default return would be just enough.
totally agree, this is my first command example.. i have to do 2 examples as per requirement :D. A default return would be just enough.
Yes that's because you used a new command issue template, while this isn't a new command but rather an enhancement. We don't have an enhancement template because it is quite hard to put it in a fixed template. Therefore you should actually use a blank issue to write down enhancements.
So for this enhancement, I don't think we need extra examples since we are only extending something that already exist.
So for this enhancement,
ahh, thanks @milanholemans , i will do this next time!
I've trimmed down your issue a bit (removed the unnecessary sections). If this looks good for you, we can start implementing it.
I've trimmed down your issue a bit (removed the unnecessary sections). If this looks good for you, we can start implementing it.
nothing to add, thanks @milanholemans
Just to give some extra context, this is not a breaking change because we will just enrich the output with extra properties that are returned by default by Graph. The already existing properties will still be there.
Nice enhancement @ValerasNarbutas! It's indeed more logical that the command would return all the available properties instead of trimming it.
Do you want to work on this issue?
Nice enhancement @ValerasNarbutas! It's indeed more logical that the command would return all the available properties instead of trimming it.
Do you want to work on this issue?
with pleasure :) @Jwaegebaert i just need my previous pull request merged, the one for typos.
with pleasure :) @Jwaegebaert i just need my previous pull request merged, the one for typos.
One small tip: when contributing to GitHub repositories like ours, the best strategy is that you create a new git branch based on your main branch, for each issue you are working on, and put your contributions for that specific issue in there. That makes sure that all your contributions are isolated on a specific branch and your main branch remains untouched (as it should be because this one should be in sync with our main). This also enables you to contribute to multiple issues at without code from issue A affecting code from issue B.
Currently you cannot do this because you already made a PR with changes on your main branch. But keep this in mind for the future.
is also enables you to contribute to multiple issues at without
this is exactly tip i needed !! @milanholemans i had it somewhere back in my mind, but never tried :) thanks.
Hey @ValerasNarbutas, just checking in. How is everything going regarding this issue?
I'll wait for the merge of Nandeeps' PR and work on this afterwards.