cli-microsoft365 Adds 'spo listitem roleassignment add' command. Closes #3539

Adds 'spo listitem roleassignment add' command

The aim of this PR is to add a new command which is suppose to add role assignemnt to given list item

Linked Issue

Closes #3539

Sep 20 '22 23:09 Adam-it

Hi @Adam-it

I see that your command still uses the old commandAction with callback function. Could you rebase again from main and refactor it to async/await please? Else we'll get errors 😊

Sep 21 '22 21:09 milanholemans

Hi @Adam-it

I see that your command still uses the old commandAction with callback function. Could you rebase again from main and refactor it to async/await please? Else we'll get errors 😊

sure will do 👍

Sep 21 '22 21:09 Adam-it

@milanholemans aligned with latest approach. Ready for review 🙂. BTW I am also taking part of hacktoberfest

Sep 30 '22 02:09 Adam-it

@Jwaegebaert all done. Thanks for your awesome review 👍 You are doing a great job 👍👍👍 I also added a separate issue like you suggested to give the opportunity for someone else to fix the naming issues https://github.com/pnp/cli-microsoft365/issues/3749

Oct 05 '22 22:10 Adam-it

@Jwaegebaert ready 👍👍👍👍

Oct 10 '22 22:10 Adam-it

should add mocking getProcessName

Oct 11 '22 22:10 Adam-it

@Adam-it before we continue with the review, could you take a look at the conflicting file.

Oct 18 '22 11:10 Jwaegebaert

@Jwaegebaert thanks for your awesome review 👍. I merged this branch with latest changes. Let me know if you will need any more help 👍

Oct 19 '22 22:10 Adam-it

@Adam-it sorry to get back to it so late but we got problems again. 😅 There are some conflicts and 23 files changed.

Oct 23 '22 21:10 Jwaegebaert

@Adam-it sorry to get back to it so late but we got problems again. 😅 There are some conflicts and 23 files changed.

done.

Oct 24 '22 00:10 Adam-it

Merged manually

Oct 25 '22 16:10 Jwaegebaert