cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

Fix options overriding aad app manifest. Closes #3555

Open martinlingstuyl opened this issue 1 year ago • 1 comments

Closes #3555

This PR fixes a bug where options would incorrectly override manifest properties:

  • Manifest scopes where merged with the options, this is now changed: when options apisDelegated or apisApplication are specified, the manifest scopes and roles are ignored.
  • the multitenant option will now override the manifest property
  • the implicitFlow option will now override the manifest property
  • the withSecret option will now no longer create two secrets when a manifest secret is present. It will not create the manifest secret.
  • the custom scope and identifier uri options will now override the manifest scope and identifier uri.
  • the certificate options will now override the manifest properties.

martinlingstuyl avatar Sep 19 '22 22:09 martinlingstuyl

Hi @martinlingstuyl

Seems like you are getting some merge conflicts, could you resolve them please?

Thank you

milanholemans avatar Sep 22 '22 06:09 milanholemans

OK @waldekmastykarz, I fixed the comments!

martinlingstuyl avatar Oct 17 '22 19:10 martinlingstuyl

Merged manually. Thank you! 👏

waldekmastykarz avatar Oct 22 '22 14:10 waldekmastykarz