cli-microsoft365 icon indicating copy to clipboard operation
cli-microsoft365 copied to clipboard

New command: m365 pp tenant settings list

Open appieschot opened this issue 2 years ago โ€ข 10 comments

Usage

m365 pp tenant settings list

Description

Lists the global power platform tenant settings

Options

Option Description

Examples

Lists the Power Platform settings of the tenant

m365 pp tenant settings list

Additional Info

See https://docs.microsoft.com/en-us/power-platform/admin/list-tenantsettings for the endpoint and settings.

Inspiration for the implementation can also be found here: https://pnp.github.io/cli-microsoft365/cmd/spo/tenant/tenant-settings-list/

As mentioned by @milanholemans right below we should add a warning in the docs that the API is in preview

appieschot avatar Sep 07 '22 11:09 appieschot

@pnp/cli-for-microsoft-365-maintainers if we agree on this one we can open this one as well ๐Ÿš€

appieschot avatar Sep 07 '22 11:09 appieschot

Looks good to me ๐Ÿ‘ According to the docs this API is in preview, so we should definitely show a warning in the docs like we do here: https://pnp.github.io/cli-microsoft365/cmd/flow/run/run-cancel/#remarks.

milanholemans avatar Sep 07 '22 11:09 milanholemans

Looks great @appieschot!

martinlingstuyl avatar Sep 07 '22 13:09 martinlingstuyl

Looks great @appieschot!

  • 1 from me on this one as well๐Ÿ‘๐Ÿ˜‰

Adam-it avatar Sep 07 '22 23:09 Adam-it

Since this is a list command, let's extend the spec with the list of properties we should show by default in text output

waldekmastykarz avatar Sep 09 '22 14:09 waldekmastykarz

Good point, the result would return this: (and will potentially grow depending on what will be added). How about we put only first level properties in the text output?

{
    "walkMeOptOut": false,
    "disableNPSCommentsReachout": false,
    "disableNewsletterSendout": false,
    "disableEnvironmentCreationByNonAdminUsers": false,
    "disablePortalsCreationByNonAdminUsers": false,
    "disableSurveyFeedback": false,
    "disableTrialEnvironmentCreationByNonAdminUsers": false,
    "disableCapacityAllocationByEnvironmentAdmins": false,
    "disableSupportTicketsVisibleByAllUsers": false,
    "powerPlatform": {
        "search": {
            "disableDocsSearch": false,
            "disableCommunitySearch": false,
            "disableBingVideoSearch": false
        },
        "teamsIntegration": {
            "shareWithColleaguesUserLimit": 10000
        },
        "powerApps": {
            "disableShareWithEveryone": false,
            "enableGuestsToMake": false
        }
    }
}

appieschot avatar Sep 12 '22 07:09 appieschot

We're limited by the width of the terminal window, so let's select the few properties people would most likely need the most.

waldekmastykarz avatar Sep 12 '22 17:09 waldekmastykarz

In that case my vote would be for disableEnvironmentCreationByNonAdminUsers and disableTrialEnvironmentCreationByNonAdminUsers as I use those the most. Other input is valued :)

appieschot avatar Sep 13 '22 06:09 appieschot

@appieschot, @waldekmastykarz: checkout the text output of spo tenant and planner tenant. We just list the entire props list there.

martinlingstuyl avatar Sep 13 '22 07:09 martinlingstuyl

@martinlingstuyl the difference there is that the returned object is one object with many properties. Typically, list commands return many items, which is why we're formatting them in a table. If the result of this call is just one item as well, then we don't need to trim the properties that we show because they won't be formatted as a table anyway.

waldekmastykarz avatar Sep 18 '22 17:09 waldekmastykarz

I would like to work on this one!

MathijsVerbeeck avatar Oct 06 '22 22:10 MathijsVerbeeck

Awesome @MathijsVerbeeck! It's all yours!

milanholemans avatar Oct 06 '22 22:10 milanholemans