pnp
Updates dependencies
After merging this PR npm outdated will return...
As per comments on the previous months update PR #3504, the following dependencies have been updated to ESM which will require further changes to upgrade to the latest major versions.
@garrytrinder rechecked locally on win. all fine ✅ let me know if you want to merge this on your own or you want me to do it 👍
Feel free to merge @Adam-it 👍
I was afraid you will say that 😅. I will merge it in my next open source time.. I hope sometime over the weekend 🤔. Assigning this to me then 👍
@garrytrinder , @waldekmastykarz before I do anything stupid just to double check. As this was not created on forked repo but on this current but still we should not just merge but rebase in order to have clean history right ?
also after that I will need to do git push with --force right ?
When you rebase, you shouldn't need to force push because the PR branch will be updated with commits from main. Happy to help with merging it if needed.
For the future, let's create working branches for PRs in forked repos.
When you rebase, you shouldn't need to force push because the PR branch will be updated with commits from main. Happy to help with merging it if needed.
For the future, let's create working branches for PRs in forked repos.
Hmm strange, I thought I had it aligned 🤔. Ok I will give it a check. If something goes wrong and I won't feel 100% sure about it maybe we could do it together really quick during a call 😉
For the future, let's create working branches for PRs in forked repos.
Absolutely @waldekmastykarz, I'm not sure what has happened here as I always work from my fork 🤷🏻♂️
@Adam-it if this is causing you issues I'm more than happy to re-raise from my fork.
@waldekmastykarz, @garrytrinder sorry for taking so long on this one. ok so just to be on the save side I rebased the july22-deps to a local prmain branch (copy of main) and then merged it to the main locally and I have the @garrytrinder changes on tops of main
You think thats ok ?
Seems like it: if your main is synced with origin/main (not sure what the red crosses in your UI are) and your local main now shows an extra commit for the dependencies, it seems fine
merge manually. Thanks for the awesome work and your help in merging this PR 😉