BUG : When navigating to popup dialog - eg. RE ORDER LINKS

[GrumpyWookie]

When clicking on the button for 'reorder links' from a "Summary Links" webpart, there is a JS error.

I've included a one line change - which solves the issue - as shown below .

This is because the page doesn't have "DeltaTopNavigation" - and so I added the line in BOLD.

Is someone able to check/agree - and then do a PULL/COMMIT ??

    setUpToggling: function () {
        /* if it is already responsivized, return */
        if (document.getElementById('navbar-toggle')) { return; }

        /* Set up sidenav toggling */
        var topNav = document.getElementById('DeltaTopNavigation');

        **_if (!topNav){ return; } // for popup dialogs - eg. re-order links_**
        
        var topNavClone = topNav.cloneNode(true);
        topNavClone.className = topNavClone.className + ' mobile-only';
        topNavClone = cloneSPIdNodes(topNavClone);

[GrumpyWookie]

Function in JS is "setUpToggling" >>

if (!topNav){ return; }

[Laul0]

Hi @GrumpyWookie, you right, your code fix this issue and another one... I suggested to check if the content is in modal dialog, but my method is less flexible than yours, that's why I updated my last PR #125

[Laul0]

Hi @GrumpyWookie, the PR was approved and merged. Your issue is solved, isn't it ?

[Laul0]

@VesaJuvonen could you set Responsive Label plz ?