Felix S Klock II

Results 239 comments of Felix S Klock II

I would like to understand where we should put our documentation for "how to run the triage meeting." Currently it lives as the description on https://github.com/rust-lang/rust/issues/54818, and while that is...

@Soveu I think at this point we want this change to be guarded by a feature gate. You can see documentation in the rustc-dev-guide on how to introduce and use...

> > The handling and lifetimes of temporaries should be exactly the same with let and with let else; any understanding or intuitions that people have about let should apply...

> we ought to extend the HIR with a specific let-else construct. Just so it isn't lost in the ether: the concrete idea is to add support for let-else on...

A couple thoughts that came up during RustConf today: 1. One particularly insidious case of these large moves is when its some local variable that is carried over a `.await`....

beta-nominating since this is a P-critical issue affecting a tier-1 target. I'm also stable-nominating because I think we should at least have the discussion about whether we would want this...

Yes, I agree with @nagisa : the run-make-fulldeps test is very fragile (in the sense that changes to the optimizations can cause the test to stop actually exercising that the...

> (I'm not quite sure yet how best to encode the _variation_ between different targets on this front; it seems like the current strategy is to put variations into distinct...

At this point I don't think its worth trying to coax a regression test out of some combination of ui + `rust_test_helpers.c`. The original test case, as captured in the...