Some minor issues in Color Settings

[Yaron10]

Hello Pavel,

STR1: Navigate with the keyboard to a combo (it gets the focus). Press F4 (or Alt+Up/Down arrows; standard Windows keys to toggle a combo).

Result: The More colors dialog does not open.

STR2: Click on a combo (the More colors dialog opens). Click again on the same spot (the More colors dialog closes).

Result: The Settings dialog does not get the focus. Would you consider it the expected behavior?

STR3: Type abc or 999 in the Highlight transparency EditBox.

Expected: Not allowed. (You can add ES_NUMBER for abc).

Enhancement: It would be nice if Esc closed the More colors dialog.

---

I've played a bit with the Settings, More colors and About dialogs. Here is the RC file. You might like some of the changes.

Whenever you find time to look into it and reply. Thank you.

BR

[pnedev]

Hello Yaron,

OK, soon, thanks.

BR

[pnedev]

Hello Yaron,

Great job with the dialogues, thank you! :+1:

Your changes are merged here: https://github.com/pnedev/compare-plugin/commit/4407ea197767cbc46c9c8d4ce900e9fa17e66f67

This is the x86 binary: https://ci.appveyor.com/api/buildjobs/40xosmilvg2it37n/artifacts/ComparePlugin.dll

The minor issues are... minor :) so I'll look at them later, thank you.

BR

[Yaron10]

Hello Pavel,

I'm glad you it. Thank you. (The Misc. group was a "filler"; I think it can be removed if another setting is added (combo: Status bar info - None, Settings, Diffs). With your permission, we'll discuss it when you get to that point. :) ).

The minor issues are... minor :) so I'll look at them later

Great. I appreciate it.

BR

[Yaron10]

Hello Pavel,

Could you please replace the following block?

if (isRTLwindow(nppData._nppHandle))
{
	SetDlgItemText(_hSelf, IDC_OLD_MAIN, TEXT("Right/Top"));
	SetDlgItemText(_hSelf, IDC_OLD_SUB, TEXT("Left/Bottom"));
}

With

if (isRTLwindow(nppData._nppHandle))
{
	SetDlgItemText(_hSelf, IDC_OLD_MAIN, TEXT("Old file in right view"));
	SetDlgItemText(_hSelf, IDC_OLD_SUB, TEXT("Old file in left view"));
}

Thank you. BR

[pnedev]

Hello Yaron,

Very good catch, thank you. :+1: It is fixed here: https://github.com/pnedev/compare-plugin/commit/facb33ce38db281193b331c7bdffb3b6e78397a8 (x86 binary)

BR

[Yaron10]

Hello Pavel,

:+1: Thank you. I appreciate it.

BR

[pnedev]

Hello Yaron,

I will postpone these minor issues and improvements for the future releases. Thanks again for pointing them out. :+1:

BR

[Yaron10]

:+1: