PMAlertController icon indicating copy to clipboard operation
PMAlertController copied to clipboard

Published 20 hours ago • verified publisher icon pmusolino

Cannot scroll

Open pbmorton opened this issue 7 years ago • 13 comments

If the alert text cannot fit on the screen the text cannot be scrolled - UIAlertController in contrast supports scrolling by default. What's worse is that the PMAlertController places the "cancel" action off the screen so a user cannot then cancel the alert. The App is effectively blocked from user interaction.

Being able to handle an alert that wont fit completely on screen is important. With devices with different configurations (e.g. screen sizes, portrait, landscape) and dynamic type sizes (i.e. through the settings App a user can increase the text size) its easy to imagine some alerts not fitting a screen.

Otherwise a great library thanks!

pbmorton avatar Mar 29 '17 08:03 pbmorton

Hi @pbmorton, great observation. I marked this issue like enhancement, i can implement this feature in a future release.

Thanks, Paolo

pmusolino avatar Mar 29 '17 08:03 pmusolino

Thanks Paolo. Can you estimate when this feature may be supported?

pbmorton avatar Apr 12 '17 05:04 pbmorton

Asap, I'll try this week ;)

pmusolino avatar Apr 12 '17 08:04 pmusolino

@Codeido Have applied the quick workaround for the scroll issue. Do check if it looks good to you https://github.com/Codeido/PMAlertController/pull/45

javalnanda avatar Apr 29 '17 22:04 javalnanda

@javalnanda thanks for this PR, but i think that your workaround is not a final solution. First of all, if you substitute the label description with a textview you break the back compatibility. This feature need to be an enhancement. 2nd: this solution include only some cases, because if you have a lot of buttons, you have a small textview for the description (probably with height == 0).

pmusolino avatar May 05 '17 12:05 pmusolino

@Codeido Makes sense, the back compatibility will be a major issue. Are you thinking of embedding entire alert view inside a scroll view?

javalnanda avatar May 05 '17 13:05 javalnanda

Yes, i think that is the best solution.

pmusolino avatar May 05 '17 13:05 pmusolino

ok, 👍 Let me know if you are already working on it. Else, I could spend some time on it the coming week.

javalnanda avatar May 05 '17 13:05 javalnanda

@Codeido Scrolling entire alert view looks really bad. Just tried out. The Default AlertController also scrolls only the text part. I think we will need to scroll only the content part except Alert Action Stack View

javalnanda avatar May 05 '17 14:05 javalnanda

@Codeido Sent one more PR, see if it is helpful. Also, I think it will be good to have a limit to the number of action buttons to max 5 or 6 maybe. Just a suggestion :)

javalnanda avatar May 05 '17 15:05 javalnanda

Hi @Codeido

thanks for this nice alert controller! Wondering if you ever got around the merging in a fix for this?

edwardmp avatar Mar 26 '18 20:03 edwardmp

@pmusolino When will the feature be implemented?

thatmarcel avatar May 18 '18 17:05 thatmarcel

It's still unscrollable, right?

sm0nster avatar Apr 09 '20 16:04 sm0nster