papermario icon indicating copy to clipboard operation
papermario copied to clipboard

Published 20 hours ago • verified publisher icon pmret

`SHIFT_BSS` be gone

Open Alto1772 opened this issue 1 year ago • 2 comments

Alto1772 avatar Feb 17 '24 02:02 Alto1772

🚀🚀🚀🚀🚀🚀🚀🚀 This PR matches 8 functions (+0.00%) on jp. 🚀 This PR matches 1 function (+0.00%) on ique.

BowserSlug avatar Feb 17 '24 02:02 BowserSlug

my main concern with this approach is the fact that making things static unfortunately makes them less visible. However, it seems like SHIFT_BSS was defined as just static in some cases anyway...hmm

Yeah good suggestion. The reason I did is to just be made as intended by the original developers. The BSS addresses located between the 2 common sections were originally meant to be static so I made it one too...

As a suggestion and my personal understanding, I'll just make the static ones visible by using BSS macro instead. (addendum: except for the libultra & nusys ones)

Alto1772 avatar Feb 17 '24 10:02 Alto1772