Results 31 comments of Panagiotis Bailis
trafficstars

Thanks @mayya-sharipova ! I'll wait a bit more for the ref counting part to see if @original-brownbear has any comments/things to address :)

@elasticmachine update branch

> what do you think of skipping the rank feature phase altogether if there are no retrievers in the search request? Currently if there is no rank builder we execute...

@elasticmachine update branch

@benwtrent I pushed some recent changes (as also per @original-brownbear 's comments) for whenever you have some time 🙇 W.r.t. skipping this phase if no reranker actually needs it, do...

@elasticmachine update branch

@elasticmachine update branch

Thanks for the reviews 🙇 Merging :)

Added a waiting check for all `free_context` actions to be consumed before validating active contexts in https://github.com/elastic/elasticsearch/pull/110595. Closing this one.

A [similar failure](https://gradle-enterprise.elastic.co/s/lpabynv6r5tdo/tests/task/:server:internalClusterTest/details/org.elasticsearch.search.sort.FieldSortIT/testSimpleSorts?top-execution=1) was raised in my PR as well -> ``` java.lang.AssertionError: |   -- | -- Expected: an empty collection |   but: ```