Pavel Mores

Results 15 comments of Pavel Mores

@Tim-0731-Hzt I pushed a new version that moves the drop-in handling implementation out to `drop_in.rs` as suggested. This is just a pure code reorganisation, none of the actual algorithms are...

@quanweiZhou I'm looking into the dragonball test failure.

@quanweiZhou Wow, there was an actual omission in `config.d` handling - good catch, CI, and shame on me! :-) I fixed that and added a couple of related tests.

@liubin Thanks for reminding me, done!

Pushed a new version to integrate @dgibson's proposals. Thank you very much for taking the time to do such a detailed review.

Pushed the remaining fixes as proposed by @dgibson. @jodh-intel Thanks! Obviously I'm happy to adjust docs but I'm afraid I'll need a hint as to what's necessary. I thought originally...

@Tim-0731-Hzt This is very useful, thanks a lot! One question I have right away: is the ConfigPlugin for QemuConfig implementation (`adjust_config()` and `validate()`) complete, or does it need further work?...

I'd consider "the first one" in the sense of individual hypervisor stanzas ordering in the `configuration.toml` text a reasonable default. However given that `TomlConfig::hypervisor` is a `HashMap`, is it even...

So I believe that we want to support this feature (and I can see how it could be useful) we'll probably have to live with a config file syntax change....