unfurl icon indicating copy to clipboard operation
unfurl copied to clipboard

[#6] Added support for ClojureScript

Open e18r opened this issue 5 years ago • 3 comments

Well, @pmonks, this is it. I moved platform-independent code to common.cljc, and platform-specific code to api.clj and api.cljs. I created a separated test suite in api_test.cljs, which uses doo and karma to run the tests, as well as a Flask back end created to get rid of CORS issues. I haven't modified the README yet. I'll do it as soon as you approve my changes.

In order to test, try running ./cljs.sh, which installs all the requirements, runs the test server and the tests. Please let me know if it doesn't work.

e18r avatar May 23 '19 20:05 e18r

Hi @pmonks, please let me know what you think about this.

e18r avatar May 27 '19 12:05 e18r

@e18r just wanted to let you know that I’ve been traveling without a laptop these last few weeks.

I haven’t forgotten about this, promise! 😄

pmonks avatar Jul 04 '19 22:07 pmonks

@pmonks Unfortunately, in its current state, the library doesn't work in react native because hickory seems to have issues with it. Since cljs-http doesn't work with Node, I wonder if there are any use cases left. As for me, I abandoned the project of adding unfurling to Status. Thank you for all your help and until next time!

e18r avatar Jul 04 '19 23:07 e18r