pmodels
coll: update the json selection of MPIR_Bcast_intra_scatter_ring_allgather
Pull Request Description
The MPIR_Bcast_intra_scatter_ring_allgather won't perform if the per_proc_msg_size (chunk size) is too small, which accumulates latency in each round.
Fixes #7330 [skip warnings]
Author Checklist
- [x] Provide Description Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
- [x] Commits Follow Good Practice
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit. - [ ] Passes All Tests Whitespace checker. Warnings test. Additional tests via comments.
- [x] Contribution Agreement For non-Argonne authors, check contribution agreement. If necessary, request an explicit comment from your companies PR approval manager.
Did you do a performance test with this, or are these changes just based on the conversation earlier this week? Its on my TODOs to do some performance runs on Aurora, so I can try testing this too
Did you do a performance test with this, or are these changes just based on the conversation earlier this week? Its on my TODOs to do some performance runs on Aurora, so I can try testing this too
Thanks for volunteering! :)
The patch is to address the obvious issue so it don't perform outrageously bad. Yes, we should use tests to finetune the threshold.