mpich icon indicating copy to clipboard operation
mpich copied to clipboard

util/async: avoid calling PMPIX_Stream_progress

Open hzhou opened this issue 1 year ago • 6 comments

Pull Request Description

We should avoid calling MPI/PMPI functions internally. In this case, PMPIX_Stream_progress is not defined in the mpi-abi build.

Fixes #7034

[skip warnings]

Author Checklist

  • [x] Provide Description Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • [x] Commits Follow Good Practice Commits are self-contained and do not do two things at once. Commit message is of the form: module: short description Commit message explains what's in the commit.
  • [ ] Passes All Tests Whitespace checker. Warnings test. Additional tests via comments.
  • [x] Contribution Agreement For non-Argonne authors, check contribution agreement. If necessary, request an explicit comment from your companies PR approval manager.

hzhou avatar Jun 26 '24 16:06 hzhou

test:mpich/custom config: mpi-abi ✔️

hzhou avatar Jun 26 '24 16:06 hzhou

mpi4py ABI build tests running: https://github.com/mpi4py/mpi4py-testing/actions/runs/9683326620/job/26718539505

dalcinl avatar Jun 26 '24 16:06 dalcinl

@hzhou mpi4py still broken, same error.

dalcinl avatar Jun 26 '24 16:06 dalcinl

@hzhou mpi4py still broken, same error.

Added a fix -- I am getting sloppy 🫠. Could you try again?

hzhou avatar Jun 26 '24 17:06 hzhou

New run just started: https://github.com/mpi4py/mpi4py-testing/actions/runs/9683326620/job/26721265683

dalcinl avatar Jun 26 '24 17:06 dalcinl

Looks like your last commit fixed the mpi4py issue.

dalcinl avatar Jun 26 '24 18:06 dalcinl

@raffenet Could you please approve this trivial PR such that the mpi4py ABI builds can get back to green?

dalcinl avatar Jul 01 '24 08:07 dalcinl