mpich icon indicating copy to clipboard operation
mpich copied to clipboard

ch4/ofi: fix MPIDI_OFI_CALL_RETRY_AM for vci

Open hzhou opened this issue 1 year ago • 1 comments

Pull Request Description

The macro needs a vci input or it will call MPIDI_OFI_progress_do_queue on the wrong vci and result in deadlock.

Somehow we miss catching this with psm3 provider testing. It is triggered by am fallback in the rma testing. It appears that only the rma testing triggers the am postponing queue path.

[skip warnings]

Author Checklist

  • [x] Provide Description Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • [x] Commits Follow Good Practice Commits are self-contained and do not do two things at once. Commit message is of the form: module: short description Commit message explains what's in the commit.
  • [ ] Passes All Tests Whitespace checker. Warnings test. Additional tests via comments.
  • [x] Contribution Agreement For non-Argonne authors, check contribution agreement. If necessary, request an explicit comment from your companies PR approval manager.

hzhou avatar Jun 26 '24 14:06 hzhou

test:mpich/ch4/ofi ✔️

hzhou avatar Jun 26 '24 14:06 hzhou

test:mpich/warnings/auto

hzhou avatar Jul 02 '24 21:07 hzhou