mpich icon indicating copy to clipboard operation
mpich copied to clipboard

test/cxx: Fix complex number comparisons

Open raffenet opened this issue 1 year ago • 2 comments

Pull Request Description

C++20 removed support for == and != on complex numbers. Instead, compare the individual parts. Fixes compilation with Intel oneAPI C++ (icpx).

Author Checklist

  • [x] Provide Description Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • [x] Commits Follow Good Practice Commits are self-contained and do not do two things at once. Commit message is of the form: module: short description Commit message explains what's in the commit.
  • [ ] Passes All Tests Whitespace checker. Warnings test. Additional tests via comments.
  • [x] Contribution Agreement For non-Argonne authors, check contribution agreement. If necessary, request an explicit comment from your companies PR approval manager.

raffenet avatar Feb 14 '24 21:02 raffenet

test:mpich/custom compiler: intel-oneapi

raffenet avatar Feb 14 '24 22:02 raffenet

After some discussion with @jeffhammond and testing on https://godbolt.org/, the errors in Jenkins look to be an incompatibility between Intel oneAPI and the base system compiler (gcc 4.8.5). It doesn't hurt to add this change, but it's likely not needed in a supported installation.

raffenet avatar Feb 15 '24 16:02 raffenet

The new Jenkins build is here and has no issue with this test. Closing.

raffenet avatar May 03 '24 16:05 raffenet