mpich icon indicating copy to clipboard operation
mpich copied to clipboard

romio: Fix wrong communicator use in ADIOI_GEN_OpenColl

Open range3 opened this issue 2 years ago • 6 comments

Pull Request Description

When ADIOI_GEN_OpenColl is called in ADIO_CREAT mode, file creation is done by calling ADIOI_xxx_Open with MPI_COMM_SELF by rank == fd->hints->ranklist[0]. If successful, the file is closed with ADIOI_xxx_Close, and later the file will be opened by all without creation flag.

The problem is that the communicator of ADIOI_GEN_OpenColl is passed to ADIOI_xxx_Close instead of MPI_COMM_SELF. If a collective call is made using this communicator in ADIOI_xxx_Close, it may hang.

Fixes: #6868

Contribution Agreement

I have sent the MPICH Individual Contributor License Agreement by e-mail and am awaiting approval.

Author Checklist

  • [x] Provide Description Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • [x] Commits Follow Good Practice Commits are self-contained and do not do two things at once. Commit message is of the form: module: short description Commit message explains what's in the commit.
  • [ ] Passes All Tests Whitespace checker. Warnings test. Additional tests via comments.
  • [ ] Contribution Agreement For non-Argonne authors, check contribution agreement. If necessary, request an explicit comment from your companies PR approval manager.

range3 avatar Jan 25 '24 10:01 range3

test:mpich/authorship test:mpich/warnings

hzhou avatar Jan 25 '24 16:01 hzhou

test:mpich/authorship

hzhou avatar Jan 25 '24 16:01 hzhou

Your message to cla awaits moderator approval

My MPICH idivisual cla is still stuck on the mailing list ([email protected]) waiting for moderator approval. Could you please confirm this?

range3 avatar Feb 09 '24 01:02 range3

Your message to cla awaits moderator approval

My MPICH idivisual cla is still stuck on the mailing list ([email protected]) waiting for moderator approval. Could you please confirm this?

We got your cla. You are all set.

hzhou avatar Feb 09 '24 03:02 hzhou

test:mpich/ch3/most test:mpich/ch4/most

hzhou avatar Feb 09 '24 03:02 hzhou

test:mpich/ch4/most

roblatham00 avatar Jun 19 '24 14:06 roblatham00