mpich icon indicating copy to clipboard operation
mpich copied to clipboard

ch4/ofi: Add CVAR to set a preferred NIC per rank

Open tarudoodi opened this issue 2 years ago • 2 comments

Pull Request Description

The PR is based on top of https://github.com/pmodels/mpich/pull/6732.

Adds a MPIR_CVAR_CH4_OFI_PREF_NIC to let the user select a NIC per rank. Also extends MPIR_CVAR_DEBUG_SUMMARY to print the NIC assigned to a rank.

Author Checklist

  • [ ] Provide Description Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • [ ] Commits Follow Good Practice Commits are self-contained and do not do two things at once. Commit message is of the form: module: short description Commit message explains what's in the commit.
  • [ ] Passes All Tests Whitespace checker. Warnings test. Additional tests via comments.
  • [ ] Contribution Agreement For non-Argonne authors, check contribution agreement. If necessary, request an explicit comment from your companies PR approval manager.

tarudoodi avatar Oct 31 '23 03:10 tarudoodi

test:mpich/ch4/ofi

tarudoodi avatar Oct 31 '23 03:10 tarudoodi

test:mpich/ch4/ofi

tarudoodi avatar Dec 15 '23 22:12 tarudoodi

test:mpich/ch4/ofi

tarudoodi avatar Mar 20 '24 19:03 tarudoodi

The ch3-tcp warnings test failed due to a cloning error: ERROR: Error cloning remote repo 'origin'

tarudoodi avatar Mar 25 '24 23:03 tarudoodi

@hzhou This is ready for review.

tarudoodi avatar Mar 25 '24 23:03 tarudoodi

Hi @hzhou, I somehow missed the review messages. I agree with your comments. I'll push an update.

tarudoodi avatar Apr 03 '24 19:04 tarudoodi

Please add commit messages for each commit.

Added.

tarudoodi avatar Apr 03 '24 21:04 tarudoodi

test:mpich/ch4/ofi

tarudoodi avatar Apr 03 '24 21:04 tarudoodi

test:mpich/ch4/ofi

tarudoodi avatar Apr 04 '24 15:04 tarudoodi

@hzhou The tests passed and rebased the branch.

tarudoodi avatar Apr 04 '24 19:04 tarudoodi

image Please do not merge main into branch. Rather, rebase on top of main.

hzhou avatar Apr 04 '24 20:04 hzhou

image Please do not merge main into branch. Rather, rebase on top of main.

Didn't expect the update button to do that. Rebased on main. Is it ok to merge after basic warning checks pass?

tarudoodi avatar Apr 04 '24 20:04 tarudoodi

Yes, you can merge it

hzhou avatar Apr 04 '24 21:04 hzhou