mpich icon indicating copy to clipboard operation
mpich copied to clipboard
verified publisher icon pmodels

misc: fix -Wconversion warnings

Open hzhou opened this issue 3 years ago • 2 comments

Pull Request Description

This is a split from #5069. This PR fixes -Wconversion warnings outside ch4 and romio.

[skip warnings]

Author Checklist

  • [x] Provide Description Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • [x] Commits Follow Good Practice Commits are self-contained and do not do two things at once. Commit message is of the form: module: short description Commit message explains what's in the commit.
  • [x] Passes All Tests Whitespace checker. Warnings test. Additional tests via comments.
  • [x] Contribution Agreement For non-Argonne authors, check contribution agreement. If necessary, request an explicit comment from your companies PR approval manager.

hzhou avatar Sep 23 '22 00:09 hzhou

test:mpich/ch4/most test:mpich/ch3/most

hzhou avatar Sep 23 '22 17:09 hzhou

I've tried going over this a couple of times. It's pretty hard to get through. I'd rather see the different types of sub-warnings split out its easier to see what's going on. That is, commits addressing -Wshorten-64-to-32 and -Wsign-conversion being treated separately. The 64-to-32 stuff is pretty straightforward. The sign conversion warnings are mainly fixed by casts which I'm hopeful we can avoid more often than not...

I agree. Let me give it a try.

hzhou avatar Oct 11 '22 16:10 hzhou