mpich icon indicating copy to clipboard operation
mpich copied to clipboard
verified publisher icon pmodels

mpl: fix configure for HIP detection

Open yfguo opened this issue 3 years ago • 1 comments

Pull Request Description

The pop on CPPFLAGS will cleanup the HIP related flags.

This PR depends on fix at https://github.com/pmodels/yaksa/pull/231.

Author Checklist

  • [ ] Provide Description Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • [ ] Commits Follow Good Practice Commits are self-contained and do not do two things at once. Commit message is of the form: module: short description Commit message explains what's in the commit.
  • [ ] Passes All Tests Whitespace checker. Warnings test. Additional tests via comments.
  • [ ] Contribution Agreement For non-Argonne authors, check contribution agreement. If necessary, request an explicit comment from your companies PR approval manager.

yfguo avatar Sep 21 '22 22:09 yfguo

The __HIP_PLATFORM_AMD__ is defined in src/mpl/include/mpl_gpu_hip.h -- https://github.com/pmodels/mpich/pull/6091/commits/69d4924f499aadab3f92134dbce38e6199c6d3f0

hzhou avatar Sep 21 '22 23:09 hzhou

The __HIP_PLATFORM_AMD__ is defined in src/mpl/include/mpl_gpu_hip.h -- 69d4924

Figured out a way to fix this cleanly.

yfguo avatar Sep 23 '22 05:09 yfguo