mpich icon indicating copy to clipboard operation
mpich copied to clipboard

maint/gen_coll: allow custom restrictions

Open hzhou opened this issue 3 years ago • 3 comments

Pull Request Description

Allow literal restriction conditions to be specified. When the restriction contains any non alphabet, comma, hyphen, or underscore, assume it is a literal condition string. Usually the condition will contain ==, &&, ||, fcall(...), etc.

[skip warnings]

Author Checklist

  • [ ] Provide Description Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
  • [ ] Commits Follow Good Practice Commits are self-contained and do not do two things at once. Commit message is of the form: module: short description Commit message explains what's in the commit.
  • [ ] Passes All Tests Whitespace checker. Warnings test. Additional tests via comments.
  • [ ] Contribution Agreement For non-Argonne authors, check contribution agreement. If necessary, request an explicit comment from your companies PR approval manager.

hzhou avatar Mar 02 '22 20:03 hzhou

@hzhou The commit is correctly generating code with the OR condition required for fallback.

srirajpaul avatar Mar 04 '22 12:03 srirajpaul

@srirajpaul Do we still need this PR to be merged?

hzhou avatar Aug 02 '22 14:08 hzhou

@hzhou oops. I do not remember the place where it was required. I think we can close it for now and reopen and merge if I encounter similar scenario in future.

srirajpaul avatar Aug 02 '22 18:08 srirajpaul