mpich
mpich copied to clipboard
maint/gen_coll: allow custom restrictions
Pull Request Description
Allow literal restriction conditions to be specified. When the
restriction contains any non alphabet, comma, hyphen, or underscore,
assume it is a literal condition string. Usually the condition will
contain ==, &&, ||, fcall(...), etc.
[skip warnings]
Author Checklist
- [ ] Provide Description Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
- [ ] Commits Follow Good Practice
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit. - [ ] Passes All Tests Whitespace checker. Warnings test. Additional tests via comments.
- [ ] Contribution Agreement For non-Argonne authors, check contribution agreement. If necessary, request an explicit comment from your companies PR approval manager.
@hzhou The commit is correctly generating code with the OR condition required for fallback.
@srirajpaul Do we still need this PR to be merged?
@hzhou oops. I do not remember the place where it was required. I think we can close it for now and reopen and merge if I encounter similar scenario in future.