autogen: fix reflect libtool patch.

[tkameyama]

Pull Request Description

autogem.sh is apllyed libtool,m4 patches in maint/patches/optional/confdb. But when autoconf and libtool are different install path, autoreconf use libtool's libtool.m4.

This PR change autoreconf -I option to -B, and use confdb/libtool.m4.

Author Checklist

• [x] Provide Description Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
• [x] Commits Follow Good Practice Commits are self-contained and do not do two things at once. Commit message is of the form: module: short description Commit message explains what's in the commit.
• [x] Passes All Tests Whitespace checker. Warnings test. Additional tests via comments.
• [] Contribution Agreement For non-Argonne authors, check contribution agreement. If necessary, request an explicit comment from your companies PR approval manager.

[hzhou]

autogen.sh generally has a more strict requirement. For example, we don't really support autotools from different install paths.

[raffenet]

autogen.sh generally has a more strict requirement. For example, we don't really support autotools from different install paths.

I agree this isn't a use-case we support. However, the proposed fix here seems low-risk to me. Am I missing something that would make this a bad idea?

[hzhou]

autogen.sh generally has a more strict requirement. For example, we don't really support autotools from different install paths.

I agree this isn't a use-case we support. However, the proposed fix here seems low-risk to me. Am I missing something that would make this a bad idea?

Now I looked into the fix, I think it is fine :) It'll be nice that we modify the comment to explain what -B does -- to prepend include paths.

[raffenet]

autogen.sh generally has a more strict requirement. For example, we don't really support autotools from different install paths.

I agree this isn't a use-case we support. However, the proposed fix here seems low-risk to me. Am I missing something that would make this a bad idea?

Now I looked into the fix, I think it is fine :) It'll be nice that we modify the comment to explain what -B does -- to prepend include paths.

Yes! Only after I looked at the manpage did I realize what was happening, which seems simple enough to try.

[hzhou]

@tkameyama Thanks for the fixes. Could you sign and send us the contribution agreement following this link http://www.mpich.org/documentation/contributor-docs/ ?

[hzhou]

@tkameyama How about squash the commits into a single commit?

[hzhou]

@tkameyama Could you sign and send us the contribution agreement http://www.mpich.org/documentation/contributor-docs/ ?