mpich icon indicating copy to clipboard operation
mpich copied to clipboard

ROMIO: add --enable-fortran configure option

Open wkliao opened this issue 5 years ago • 6 comments

Pull Request Description

Note MPICH configure option --enable-fortran/--disable-fortran is passed down to ROMIO.

Expected Impact

Author Checklist

  • [ ] Reference appropriate issues (with "Fixes" or "See" as appropriate)
  • [ ] Remove xfail from the test suite when fixing a test
  • [x] Commits are self-contained and do not do two things at once
  • [x] Commit message is of the form: module: short description and follows good practice
  • [x] Passes whitespace checkers
  • [ ] Passes warning tests
  • [ ] Passes all tests
  • [ ] Add comments such that someone without knowledge of the code could understand
  • [x] You or your company has a signed contributor's agreement on file with Argonne
  • [x] For non-Argonne authors, request an explicit comment from your companies PR approval manager

wkliao avatar Jul 04 '20 09:07 wkliao

@wkliao This one looks fine to merge. Could you rebase this PR?

hzhou avatar Jun 14 '21 00:06 hzhou

Sorry that I forgot about this one. The options in main mpich configure has changed a little. The current fortran options are --

https://github.com/pmodels/mpich/blob/3494619ecdd413427f7638e274c9f70a1960e80a/configure.ac#L441-L452

These are already in my changes.

wkliao avatar Apr 18 '22 18:04 wkliao

That is a very old code. I believe it is to figure out MPI_OFFSET_KIND and save in include/mpiof.h, as KIND is introduced in F90.

      INTEGER MPI_OFFSET_KIND
      PARAMETER (MPI_OFFSET_KIND=           8)

or

      INTEGER MPI_OFFSET_KIND
      PARAMETER (MPI_OFFSET_KIND=           4)

wkliao avatar Apr 20 '22 03:04 wkliao

That is a very old code. I believe it is to figure out MPI_OFFSET_KIND and save in include/mpiof.h, as KIND is introduced in F90.

      INTEGER MPI_OFFSET_KIND
      PARAMETER (MPI_OFFSET_KIND=           8)

or

      INTEGER MPI_OFFSET_KIND
      PARAMETER (MPI_OFFSET_KIND=           4)

If it is trying to test whether it is F90 compiler, I think we can simply remove the check. MPICH is now requiring F90 compilers. And today it is difficult to find a legacy F77 compiler in the wild anyway.

hzhou avatar Apr 20 '22 19:04 hzhou

It is not to test whether the Fortran compiler is a F90. That codes update include/mpiof.h. However, I think mpiof.h can be removed completely. as mpif.h has already covered all the necessities. There can be a separate new PR for that task. FYI. A related PR is #4693

wkliao avatar Apr 20 '22 21:04 wkliao

It is not to test whether the Fortran compiler is a F90. That codes update include/mpiof.h. However, I think mpiof.h can be removed completely. as mpif.h has already covered all the necessities. There can be a separate new PR for that task. FYI. A related PR is #4693

#4693 is merged!

hzhou avatar Apr 20 '22 21:04 hzhou