uikit icon indicating copy to clipboard operation
uikit copied to clipboard

[spike] make root optional in container

Open itsdouges opened this issue 1 year ago • 1 comments

Hey @bbohlender here's a quick spike to test the waters. We'd conditionally render <Root> if it's missing in what we'd consider "top level components".

Should that be all components? If you have a list that should be changed and are happy with the approach I can do it all, add tests, and get it into a mergeable state.

itsdouges avatar Jun 06 '24 22:06 itsdouges

@itsdouges thanks for the PR it's a good start. There are a few open questions for me:

  • Root currently has a few special properties (e.g. pixelSize that would need to be present on a Container/Text now or configured through a context further up the tree)
  • Root already is a Container so <Root><Container></...></...> is unnecessary
  • how can we propagate the idea to vanilla uikit to ensure both have a very similar API

Would love to discuss possible solutions and consolidate ideas to solve these things :)

bbohlender avatar Jun 07 '24 07:06 bbohlender

going to close this, as its already part of the uikit 1.0 roadmap

bbohlender avatar May 05 '25 06:05 bbohlender