Fix broken tests, a bug fix for text boxes with `number`s in them, and CI setup.

Open myers opened this issue 2 months ago • 3 comments

This fixes the tests, adds CI setup that should show you if the test break again, and fixes a bug when a page number box has a number in it.

Oct 02 '25 01:10 myers

thanks for the PR

currently the typings do not support numbers, but as I just learned writing <Button>123</Button> in react provides the children as a number so it might be a good idea to adapt the types also

Regarding the tests you are adding "waitForEffects" which I am not getting since I am using the synchronous veryion of preact/signals. Is there a reason you are doing this?

Oct 02 '25 18:10 bbohlender

@bbohlender fixed!

turns out boolean values could be there too.

I didn't understand what was happening with the sync version of preact/signals

Oct 03 '25 23:10 myers

@bbohlender I think this is ready for a re-review.

Nov 09 '25 18:11 myers