three-stdlib icon indicating copy to clipboard operation
three-stdlib copied to clipboard

Expected publicly documented methods of ArcballControls to be public

Open IkonOne opened this issue 1 year ago • 2 comments

  • three version: ^0.164.1
  • @types/three version: ^0.164.1
  • three-stdlib version: ^2.30.1

Problem description:

Many public and documented methods on ArcballControls are marked private in three-stdlib.

Relevant code:

...

Suggested solution:

Replace the private access modifier with public.

Are these marked private intentionally?

IkonOne avatar Oct 22 '24 04:10 IkonOne

related: #372

IkonOne avatar Oct 22 '24 04:10 IkonOne

I think this is just an oversight. Can someone please confirm that it is and I can make a PR.

IkonOne avatar Oct 22 '24 04:10 IkonOne