three-stdlib icon indicating copy to clipboard operation
three-stdlib copied to clipboard

refactor: types ARButton and VRButton

Open DylanTackoor opened this issue 4 years ago • 1 comments

What

  • ARButton.js -> ARButton.ts
  • VRButton.js -> VRButton.ts

Why

Types XRButtons. Didn't see an issue tracking these in any of the typing milestones so no worries if it's too early to merge this. Just wanted to fix something inbetween working on typing the loaders as they're taking a while.

Checklist

  • [x] Ready to be merged

DylanTackoor avatar Mar 08 '21 03:03 DylanTackoor

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/three-stdlib/7Y5z8x3YrQqzzG4zL48E1EDpSNds
✅ Preview: Failed

[Deployment for 3b1517f failed]

vercel[bot] avatar Mar 09 '21 17:03 vercel[bot]

Continuing in #241. three.js has broken a lot of stuff around WebXR and its renderers since.

CodyJasonBennett avatar May 26 '23 19:05 CodyJasonBennett