react-three-fiber icon indicating copy to clipboard operation
react-three-fiber copied to clipboard

feat(native): implement native EventTarget methods

Open CodyJasonBennett opened this issue 1 year ago • 1 comments

Resolves #3173

CodyJasonBennett avatar May 05 '24 22:05 CodyJasonBennett

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 46d81ce1d714c54a31106cd596d43542afa2e8b8:

Sandbox Source
example Configuration

codesandbox-ci[bot] avatar May 05 '24 22:05 codesandbox-ci[bot]

What is the state of this PR?

TiagoCavalcante avatar Aug 03 '24 21:08 TiagoCavalcante

I need to test this and see how far off we are from supporting controls from three/examples, or libraries like pmndrs/use-gesture which are a bit more elaborate with usage. This was put on the backburner as we had some core issues with our events model for XR, which may be relevant for multi-touch or general correctness. We found an elegant way to continue which we'll implement later, so this doesn't need to be blocked. This PR just needs to support controls and the previous suspects that made canvas event props not work as they should. We may be able to backport the latter alongside #3315 if this takes too long.

CodyJasonBennett avatar Aug 04 '24 17:08 CodyJasonBennett

Waiting for this update as well. I tried my hand at implementing the gestures on my own from react native gesture handler but canvas doesn't seem to be receiving any of the events from that.

ashkalor avatar Aug 09 '24 13:08 ashkalor

I'm back from SIGGRAPH and work this week, so I'll be continuing here. I think for responder props to work on the canvas, {...bind} needs to be moved to the GLView or a hidden View where we don't spread user-land props.

CodyJasonBennett avatar Aug 10 '24 00:08 CodyJasonBennett

@CodyJasonBennett, Hey there seems to be no typings in the latest release. Declarations folder is not present for v18.17.1 inside node_modules when i checked.

ashkalor avatar Aug 10 '24 15:08 ashkalor

Fixed. #3331.

CodyJasonBennett avatar Aug 10 '24 15:08 CodyJasonBennett