react-three-editor icon indicating copy to clipboard operation
react-three-editor copied to clipboard

`_source` added to Fragment

Open hasparus opened this issue 3 years ago • 1 comments

Sup folks. Firstly, I love this package. Thank you so much for your work on it.

I've encountered the following error from React.

`_source` supplied to `React.Fragment`. React.Fragment can only have `key` and `children` props.

_source is added to props of every element, including fragments. After a quick skim of the code, I think it happens here: https://github.com/pmndrs/react-three-editor/blob/main/packages/vite/src/babel/babel.ts#L240-L253

I suppose I should ask — can anything break if I added an if statement there to avoid adding _source to Fragments? Is there any other piece of the code that expects _source to be given to all elements?

hasparus avatar Jan 08 '23 12:01 hasparus

No that would be perfect!

nksaraf avatar Jan 08 '23 21:01 nksaraf