react-postprocessing icon indicating copy to clipboard operation
react-postprocessing copied to clipboard

Published 20 hours ago • verified publisher icon pmndrs

Lensflare update

Open ektogamat opened this issue 2 years ago • 4 comments
trafficstars

  • [x] non minified version of glsl
  • [x] resize/re-render issue
  • [x] added a CSB ex

ektogamat avatar Jul 20 '23 13:07 ektogamat

is this safe to merge?

talentlessguy avatar Aug 12 '23 08:08 talentlessguy

nope, waiting for review

abernier avatar Aug 12 '23 16:08 abernier

Would it be preferable to consume the implementation from https://github.com/ektogamat/R3F-Ultimate-Lens-Flare via NPM?

CodyJasonBennett avatar Aug 23 '23 13:08 CodyJasonBennett

Would it be preferable to consume the implementation from https://github.com/ektogamat/R3F-Ultimate-Lens-Flare via NPM?

Hey Cody. Thank you for the feedback. That is possible, but I would say that it would limit its usage because most of the devs might never find it. Having this inside the library would make it easier to find and help many developers in the future. But I can understand that I'm not being very helpful in porting it to TypeScript due to my lack of knowledge in this field.

ektogamat avatar Aug 23 '23 13:08 ektogamat