postprocessing icon indicating copy to clipboard operation
postprocessing copied to clipboard
verified publisher icon pmndrs

Implement color grading effects

Open vanruesc opened this issue 1 year ago • 4 comments

Description

Implement a CDLEffect ~~BrightnessContrastEffect, HueSaturationEffect and SepiaEffect~~.

Reference:

  • https://en.wikipedia.org/wiki/ASC_CDL

Tasks

  • [ ] Create CDLEffect.
  • [ ] Create cdl demo.
  • [ ] Add unit test.

Implementation Details

  • Use brightness-contrast, hue-saturation and sepia manual demos from v6 as reference.

vanruesc avatar Feb 16 '24 15:02 vanruesc

I might suggest going an additional step and include a CDLEffect, based on ASC CDL v1.2 color grading. It's a single effect with four parameters (vec3 slope, vec3 offset, vec3 power, float saturation) that should be able to accomplish everything supported by the other effects listed here. I'm making a similar proposal for three.js core fairly soon.

donmccurdy avatar Feb 17 '24 17:02 donmccurdy

That's even better :+1: I'll update the task.

vanruesc avatar Feb 17 '24 17:02 vanruesc

FYI: this ticket is not a blocker for v7 and since I'm not familiar with CDL, I'll leave you to it @donmccurdy. Meaning I won't be checking in here :smile:

vanruesc avatar Mar 14 '24 15:03 vanruesc

Thanks @vanruesc! Next on my list after a glTF Transform v4 release that has been taking me longer than planned. 😅

donmccurdy avatar Mar 14 '24 15:03 donmccurdy