meshline icon indicating copy to clipboard operation
meshline copied to clipboard

in 3.3.1 the end of the line flickers like crazy

Open yspreen opened this issue 1 year ago • 2 comments

compare 3.2.0 https://codesandbox.io/p/sandbox/snowy-cdn-74l2v3
to 3.3.1 https://codesandbox.io/p/sandbox/zealous-chebyshev-8hj3fv

it appears that 3.3.0 is fine too

yspreen avatar Jul 19 '24 19:07 yspreen

With 3.2.0 version, the end of the line doesn't flicker definitely, but the beginning of the line flickers... You didn't notice it because the beginning of the line was out of the screen. https://codesandbox.io/p/sandbox/pensive-minsky-6qwc9j?file=/App.js

With 3.3.1 version, the beginning doesn't flicker any more, but, as you said, the end flickers...

Strange 😂

wy-luke avatar Aug 13 '24 09:08 wy-luke

This issue is caused by the changes done to fix #19.

Speciffically it's the use of this.copyV3 in the else clauses that causes the flickering.

Reverting the two else-clauses in MeshLineGeometry.ts seems to remove the flickering (but of course cause regress #19).

gorantheviking avatar Aug 18 '24 12:08 gorantheviking