leva icon indicating copy to clipboard operation
leva copied to clipboard

One

Open dbismut opened this issue 3 years ago • 7 comments

This PR will result in v1.0.0 of Leva. It will include breaking changes.

It aims at:

  • [x] migrate to pnpm instead of yarn
  • [x] upgrade to React 18
  • [ ] use the startTransition API
  • [x] upgrade to zustand v4
  • [x] rename the transient option key to reactive
  • [ ] sync with external stores
  • [ ] move away from stitches if necessary
  • [ ] resizable panel?

Todo :

  • [ ] Add husky
  • [ ] Properly configure actions
  • [ ] Re-upgrade to use-gesture 10.2.23

dbismut avatar Nov 27 '22 08:11 dbismut

🦋 Changeset detected

Latest commit: 438ea96bb721c42fa9d3dee60a47c7535449649d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
leva Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Nov 27 '22 08:11 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
leva ❌ Failed (Inspect) Jan 22, 2025 11:24pm

vercel[bot] avatar Nov 27 '22 08:11 vercel[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5e03da058b2d2c3b0d153b8d2bad9c6be630abe3:

Sandbox Source
leva-minimal Configuration
leva-busy Configuration
leva-scroll Configuration
leva-advanced-panels Configuration
leva-ui Configuration
leva-theme Configuration
leva-transient Configuration
leva-plugin-plot Configuration
leva-plugin-bezier Configuration
leva-plugin-spring Configuration
leva-plugin-dates Configuration
leva-custom-plugin Configuration

codesandbox-ci[bot] avatar Nov 27 '22 08:11 codesandbox-ci[bot]

Looks like startTransition is going to be difficult to handle with zustand. Not sure how to tackle this atm.

dbismut avatar Dec 03 '22 09:12 dbismut

Looks like startTransition is going to be difficult to handle with zustand. Not sure how to tackle this atm.

postpone it for 1.1.0? 😅

abernier avatar Dec 04 '22 23:12 abernier

What's the thinking behind going away from stitches? are there issues with the library?

My context is that im building pmndrs/react-three-editor on top of leva and using the stiches styled stuff for building custom controls with themes UIs. And it has been pretty kind to me uptil now.

nksaraf avatar Dec 14 '22 11:12 nksaraf

My fear is that stitches isn't compatible with server components and there's no plan to support them.

Not that Leva will ever make use of RSC, but the Fact that stitches doesn't seem to be a viable 100% complete react styling solution is a concern in its popularity and familiarity.

There are several threads on their GitHub about Stitches being maintained.

I haven't dug into this yet so I might be wrong. But that's my concern.

Edit: maybe stitches isn't compatible with Concurrent mode rather than RSC not exactly sure.

dbismut avatar Dec 14 '22 12:12 dbismut