ecctrl icon indicating copy to clipboard operation
ecctrl copied to clipboard

React 19

Open paulocoutinhox opened this issue 9 months ago • 4 comments

Hi,

Can you please update to React 19?

Error:

chunk-KNK3UTB7.js?v=ae6950dd:5305 Uncaught TypeError: import_react_dom6.default.render is not a function
    at render (ecctrl.js?v=ae6950dd:5923:29)
    at ecctrl.js?v=ae6950dd:11460:11
    at react-stack-bottom-frame (chunk-HQOX6EPQ.js?v=ae6950dd:10257:20)
    at runWithFiberInDEV (chunk-HQOX6EPQ.js?v=ae6950dd:638:18)
    at commitHookEffectListMount (chunk-HQOX6EPQ.js?v=ae6950dd:6678:123)
    at commitHookPassiveMountEffects (chunk-HQOX6EPQ.js?v=ae6950dd:6736:60)
    at reconnectPassiveEffects (chunk-HQOX6EPQ.js?v=ae6950dd:8137:13)
    at recursivelyTraverseReconnectPassiveEffects (chunk-HQOX6EPQ.js?v=ae6950dd:8116:11)
    at reconnectPassiveEffects (chunk-HQOX6EPQ.js?v=ae6950dd:8175:13)
    at recursivelyTraverseReconnectPassiveEffects (chunk-HQOX6EPQ.js?v=ae6950dd:8116:11)
The error message import_react_dom6.default.render is not a function indicates that the ecctrl library is trying to use the legacy ReactDOM.render() method, which has been removed in React 18 and above. In React 18+, the recommended way to render is using createRoot.

The R3F already is using version 19: https://github.com/pmndrs/react-three-fiber/blob/master/package.json

Thanks.

paulocoutinhox avatar Mar 17 '25 10:03 paulocoutinhox

Would really like this to be updated to React 19, any plans for this?

envoy1084 avatar Apr 01 '25 11:04 envoy1084

Would really like this to be updated to React 19, any plans for this?

awesome

turkyden avatar Apr 05 '25 13:04 turkyden

I see that the push request wasn't accepted; did you guys manage to get it to work with react 19?

pierroo avatar May 16 '25 10:05 pierroo

React 19 should work with v1.0.94 now. Let me know if you run into any issues

ErdongChen-Andrew avatar Jun 30 '25 17:06 ErdongChen-Andrew